xitep opened a new pull request, #1979: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1979
* Optional support for `:name` as a parameters in queries; initially requested through #291 * The naming convention chosen here is based on the java persistence api spec (https://jakarta.ee/specifications/persistence/3.2/jakarta-persistence-spec-3.2#a4401) and should fit in well * The support here is already at the level of the tokenizer, to get the span of the whole placeholder right (i'm actually interested in replace the parameter in the original query) * in fact, sqlparser's [parser](https://github.com/apache/datafusion-sqlparser-rs/blob/main/src/parser/mod.rs#L9591) combines a colon token followed by a word token into a placeholder, but does not adjust the span of the resulting ast node :/ and allows for whitespace between the colon and the word. this is something i wanted to avoid, but i'm don't feel confident to change the parser without breaking already existing functionality (if any) based on this behaviour. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
