alamb commented on code in PR #16916: URL: https://github.com/apache/datafusion/pull/16916#discussion_r2240760143
########## .github/workflows/ci.yml: ########## @@ -0,0 +1,18 @@ +name: CI + +on: + push: + branches: [ main ] + pull_request: + +jobs: + fmt: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + + - name: Install Rust nightly + run: rustup toolchain install nightly + + - name: Run rustfmt (nightly) + run: cargo +nightly fmt --all -- --config format_code_in_doc_comments=true Review Comment: Thank you @yazanmashal03 I am not sure what this check is doing - it seems to just run the fmt rather than check its output, for example ########## rustfmt.toml: ########## @@ -17,6 +17,7 @@ edition = "2021" max_width = 90 +format_code_in_doc_comments = true # nightly-only feature Review Comment: When I run `cargo fmt` now locally I see many warnings like this ``` (venv) andrewlamb@Andrews-MacBook-Pro-3:~/Software/datafusion$ cargo fmt Warning: can't set `format_code_in_doc_comments = true`, unstable features are only available in nightly channel. Warning: can't set `format_code_in_doc_comments = true`, unstable features are only available in nightly channel. Warning: can't set `format_code_in_doc_comments = true`, unstable features are only available in nightly channel. Warning: can't set `format_code_in_doc_comments = true`, unstable features are only available in nightly channel. Warning: can't set `format_code_in_doc_comments = true`, unstable features are only available in nightly channel. Warning: can't set `format_code_in_doc_comments = true`, unstable features are only available in nightly channel. Warning: can't set `format_code_in_doc_comments = true`, unstable features are only available in nightly channel. ``` Which I think means we have to wait until this feature is actually released in stable Rust to add it to this file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
