goldmedal commented on code in PR #16963:
URL: https://github.com/apache/datafusion/pull/16963#discussion_r2242317902
##########
datafusion/sql/src/planner.rs:
##########
@@ -147,10 +159,60 @@ impl From<&SqlParserOptions> for ParserOptions {
enable_options_value_normalization: options
.enable_options_value_normalization,
collect_spans: options.collect_spans,
+ default_null_ordering:
options.default_null_ordering.as_str().into(),
}
}
}
+/// Represents the null ordering for sorting expressions.
+#[derive(Debug, Clone, Copy)]
+pub enum NullOrdering {
+ /// Nulls appear last in ascending order.
+ NullsMax,
+ /// Nulls appear first in descending order.
+ NullsMin,
+ /// Nulls appear first.
+ NullsFirst,
+ /// Nulls appear last.
+ NullsLast,
+}
+
+impl NullOrdering {
+ /// Evaluates the null ordering based on the given ascending flag.
+ ///
+ /// # Returns
+ /// * `true` if nulls should appear first.
+ /// * `false` if nulls should appear last.
+ pub fn eval(&self, asc: bool) -> bool {
Review Comment:
Make sense to me. It's better 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
