iffyio commented on code in PR #1984:
URL: 
https://github.com/apache/datafusion-sqlparser-rs/pull/1984#discussion_r2247618510


##########
src/ast/data_type.rs:
##########
@@ -346,7 +346,14 @@ pub enum DataType {
     /// [1]: 
https://docs.databricks.com/aws/en/sql/language-manual/data-types/timestamp-ntz-type
     TimestampNtz,
     /// Interval type.
-    Interval,
+    ///
+    /// Optional [Postgres] field list and precision: `interval [ fields ] [ 
(p) ]`
+    ///
+    /// [Postgres]: https://www.postgresql.org/docs/17/datatype-datetime.html
+    Interval {
+        fields: Option<IntervalFields>,
+        precision: Option<u64>,

Review Comment:
   ```suggestion
       Interval {
          /// `Example syntax`
          ///
          /// [Postgres]: 
https://www.postgresql.org/docs/17/datatype-datetime.html
           fields: Option<IntervalFields>,
           /// `Example syntax`
          ///
          /// [Postgres]: 
https://www.postgresql.org/docs/17/datatype-datetime.html
           precision: Option<u64>,
   ```
   Could we move the documentation to the individual properties?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to