aharpervc commented on code in PR #1949:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1949#discussion_r2248418391
##########
src/parser/mod.rs:
##########
@@ -266,6 +266,22 @@ impl ParserOptions {
self.unescape = unescape;
self
}
+
+ /// Set if semicolon statement delimiters are required.
Review Comment:
> In terms of which way to configure, I'm guessing it could make more sense
to have the flag as a parser setting
This seems reasonable to me in terms of philosophy. However, I don't know
how that could be implemented practically. I.e., how would you write that code
in this project to be able to have the same test coverage?
The benefit of setting the parse option based on the dialect configuration
is:
1. not all dialects support parsing without semicolons (so far, only one)
2. for dialects that require semicolons, we probably don't want anything to
change (as is implemented here in the PR)
3. this project's tests are oriented around dialect features, so
implementing the semicolon requirement as a dialect feature makes it more clear
for how to run the tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
