lorenarosati commented on code in PR #16950:
URL: https://github.com/apache/datafusion/pull/16950#discussion_r2248548378
##########
datafusion/substrait/src/logical_plan/consumer/expr/scalar_function.rs:
##########
@@ -113,6 +122,15 @@ pub fn name_to_op(name: &str) -> Option<Operator> {
}
}
+pub fn substrait_to_df_name(name: &str) -> Option<&str> {
+ match name {
+ "sign" => Some("signum"),
+ "is_nan" => Some("isnan"),
+ "logb" => Some("log"),
Review Comment:
Just made this change! I removed sign and logb, and I'll handle logb as part
of the PR you linked
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
