andygrove commented on code in PR #2054:
URL: https://github.com/apache/datafusion-comet/pull/2054#discussion_r2248981021
##########
docs/source/user-guide/expressions.md:
##########
@@ -35,14 +35,14 @@ The following Spark expressions are currently available.
Any known compatibility
## Binary Arithmetic
-| Expression | Notes |
-|------------------------| ----- |
-| Add (`+`) | |
-| Subtract (`-`) | |
-| Multiply (`*`) | |
-| Divide (`/`) | |
-| IntegralDivide (`div`) | |
-| Remainder (`%`) | |
+| Expression | Notes
|
+|------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| Add (`+`) |
|
+| Subtract (`-`) |
|
+| Multiply (`*`) |
|
+| Divide (`/`) |
|
+| IntegralDivide (`div`) | All operands are cast to DecimalType (in case the
input type is not already decima type) with precision 19 and scale 0. Please
set `spark.comet.cast.allowIncompatible` to `true` to rely on DataFusion’s cast
operation for LongType inputs. |
Review Comment:
Small suggestion:
```suggestion
| IntegralDivide (`div`) | All operands are cast to DecimalType (in case the
input type is not already decima type) with precision 19 and scale 0. Please
set `spark.comet.cast.allowIncompatible` to `true` to enable DataFusion’s cast
operation for LongType inputs. |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
