leung-ming commented on PR #1915: URL: https://github.com/apache/datafusion-comet/pull/1915#issuecomment-3156012433
> Could this be done in the original crate? I understand that the original point of making the methods private is probably because the algorithm is intended specifically for int/float to string (not decimal) and also because the rust implementation appears to be for the purpose of testing. But if the reference implementation exposes the decimal interface then perhaps the original author might be okay with making the rust methods public too. Sorry for the long delay. Given that dragonbox looks not quite responteive, I opened an issue on schubfach_rs to discuss about it at https://github.com/blueglyph/schubfach_rs/issues/1 and I think what he say is reasonable. Maybe we should fork one or just use [ryu_floating_decimal](https://crates.io/crates/ryu_floating_decimal)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
