pepijnve opened a new pull request, #17131:
URL: https://github.com/apache/datafusion/pull/17131

   ## Which issue does this PR close?
   
   - Closes #17128.
   
   ## Rationale for this change
   
   `chr(0)` is supported by many other SQL implementations. The original 
rationale stated in the source code that the value cannot be stored in text 
data structures does not seems to be valid (at least not anymore today).
   
   ## What changes are included in this PR?
   
   Remove the explicit check for `0` input values.
   
   ## Are these changes tested?
   
   Yes, relevant SLT tests have been adjusted.
   
   ## Are there any user-facing changes?
   
   `chr(0)` no longer returns an error. The existing behavior was not 
documented, so documentation change is not required.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to