alamb commented on PR #17266: URL: https://github.com/apache/datafusion/pull/17266#issuecomment-3216610654
> I just pushed some changes the implement the summary output. I get the feeling we're about to learn quite a lot... Yes indeed -- I think this will be super valuable > Are you thinking the InstrumentedObjectStoreRegistry would just pass back the provided inner object store when profiling is disabled? This seems a bit more complicated to me than either using the instrumented registry or not depending on the CLI flag. Can you help me understand the benefit you think it brings? Yes that is what I was thinking I agree the implementation would be more complicated, but it would be easier to use (people wouldn't have to run datafusion-cli with a flag and then *also* have to enable/disable profiling) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
