parthchandra commented on code in PR #2044:
URL: https://github.com/apache/datafusion-comet/pull/2044#discussion_r2308725990
##########
native/spark-expr/src/conversion_funcs/cast.rs:
##########
@@ -866,6 +867,40 @@ pub fn spark_cast(
}
}
+// copied from datafusion common scalar/mod.rs
+fn dict_from_values<K: ArrowDictionaryKeyType>(
Review Comment:
@mbutrovich @comphead can we go ahead with this PR? I've verified that using
the cast kernel directly does not work for this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
