comphead commented on code in PR #2057:
URL: https://github.com/apache/datafusion-comet/pull/2057#discussion_r2325377904
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -711,8 +715,53 @@ object QueryPlanSerde extends Logging with CometExprShim {
binding,
(builder, binaryExpr) => builder.setNeqNullSafe(binaryExpr))
+ case GreaterThan(left, right) =>
+ createBinaryExpr(
+ expr,
+ left,
+ right,
+ inputs,
+ binding,
+ (builder, binaryExpr) => builder.setGt(binaryExpr))
+
+ case GreaterThanOrEqual(left, right) =>
+ createBinaryExpr(
+ expr,
+ left,
+ right,
+ inputs,
+ binding,
+ (builder, binaryExpr) => builder.setGtEq(binaryExpr))
+
+ case LessThan(left, right) =>
+ createBinaryExpr(
+ expr,
+ left,
+ right,
+ inputs,
+ binding,
+ (builder, binaryExpr) => builder.setLt(binaryExpr))
+
+ case LessThanOrEqual(left, right) =>
+ createBinaryExpr(
+ expr,
+ left,
+ right,
+ inputs,
+ binding,
+ (builder, binaryExpr) => builder.setLtEq(binaryExpr))
+
case Literal(value, dataType)
- if supportedDataType(dataType, allowComplex = value == null) =>
+ if supportedDataType(
+ dataType,
+ allowComplex = value == null ||
+ // Nested literal support for native reader
+ // can be tracked
https://github.com/apache/datafusion-comet/issues/1937
+ // now supports only Array of primitive
+ (Seq(CometConf.SCAN_NATIVE_ICEBERG_COMPAT,
CometConf.SCAN_NATIVE_DATAFUSION)
Review Comment:
I'm working on this @wForget it works but has some issues with Spark 4.0
which I found in https://github.com/apache/datafusion-comet/pull/2181
Hope it would be fixed soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
