rkrishn7 commented on code in PR #17452:
URL: https://github.com/apache/datafusion/pull/17452#discussion_r2329030129
##########
datafusion/core/tests/physical_optimizer/filter_pushdown/util.rs:
##########
@@ -61,6 +62,12 @@ impl FileOpener for TestOpener {
_file_meta: FileMeta,
_file: PartitionedFile,
) -> Result<FileOpenFuture> {
+ if let Some(predicate) = &self.predicate {
Review Comment:
Hey @adriangb, I modified the existing partitioned test to inspect metrics
from the probe side scan and verify rows are correctly being filtered out
there. I think we can get away without the delay since I applied the patch to
main and it was flaky as expected. Does that sound good to you or did you have
something else in mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
