findepi commented on code in PR #17442:
URL: https://github.com/apache/datafusion/pull/17442#discussion_r2330204546
##########
datafusion/physical-expr-common/src/sort_expr.rs:
##########
@@ -414,27 +427,28 @@ impl LexOrdering {
self.exprs.truncate(len);
true
}
+}
- /// Constructs a new `LexOrdering` from the given sort requirements w/o
- /// enforcing non-degeneracy. This function is used internally and is not
- /// meant (or safe) for external use.
- fn construct(exprs: impl IntoIterator<Item = PhysicalSortExpr>) -> (bool,
Self) {
- let mut set = HashSet::new();
- let exprs = exprs
- .into_iter()
- .filter_map(|s| set.insert(Arc::clone(&s.expr)).then_some(s))
- .collect();
- (!set.is_empty(), Self { exprs, set })
+impl PartialEq for LexOrdering {
+ fn eq(&self, other: &Self) -> bool {
+ let Self {
+ exprs,
+ set: _, // derived from `exprs`
+ } = self;
+ // PartialEq must be consistent with PartialOrd
+ exprs == &other.exprs
}
}
-
+impl Eq for LexOrdering {}
impl PartialOrd for LexOrdering {
/// There is a partial ordering among `LexOrdering` objects. For example,
the
/// ordering `[a ASC]` is coarser (less) than ordering `[a ASC, b ASC]`.
/// If two orderings do not share a prefix, they are incomparable.
fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
- self.iter()
- .zip(other.iter())
+ // PartialEq must be consistent with PartialOrd
Review Comment:
PartialEq, Eq are ment to do fewer operations, the PartialOrd was changed
only to emphasize it's correctly implemented. It's a stylistic change. See also
commit-level comment in the first commit
(https://github.com/apache/datafusion/pull/17442/commits/f37f701577b0ee9a7f155072fcda29cf2cd2d99e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
