andygrove commented on code in PR #2346:
URL: https://github.com/apache/datafusion-comet/pull/2346#discussion_r2334081254
##########
common/src/main/scala/org/apache/comet/vector/NativeUtil.scala:
##########
@@ -96,6 +96,30 @@ class NativeUtil {
(0 until batch.numCols()).foreach { index =>
batch.column(index) match {
+ case selectionVector: CometSelectionVector =>
Review Comment:
The code for `CometSelectionVector` and `CometVector` is almost identical. A
helper method `exportSingleVector` was added that is also similar. Was the
intention to call that rather than duplicate this code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
