findepi commented on code in PR #17515:
URL: https://github.com/apache/datafusion/pull/17515#discussion_r2344236784
##########
datafusion/expr/src/udf.rs:
##########
@@ -233,7 +233,25 @@ impl ScalarUDF {
///
/// See [`ScalarUDFImpl::invoke_with_args`] for details.
pub fn invoke_with_args(&self, args: ScalarFunctionArgs) ->
Result<ColumnarValue> {
- self.inner.invoke_with_args(args)
+ #[cfg(debug_assertions)]
Review Comment:
yeah, match on invoke_with_args result is useless, the `?` is the way to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
