kosiew commented on code in PR #1222:
URL:
https://github.com/apache/datafusion-python/pull/1222#discussion_r2346163736
##########
src/record_batch.rs:
##########
@@ -84,15 +84,21 @@ impl PyRecordBatchStream {
}
}
+/// Polls the next batch from a `SendableRecordBatchStream`, converting the
`Option<Result<_>>` form.
+pub(crate) async fn poll_next_batch(
+ stream: &mut SendableRecordBatchStream,
+) -> datafusion::error::Result<Option<RecordBatch>> {
+ stream.next().await.transpose()
+}
+
async fn next_stream(
stream: Arc<Mutex<SendableRecordBatchStream>>,
sync: bool,
) -> PyResult<PyRecordBatch> {
let mut stream = stream.lock().await;
- match stream.next().await {
- Some(Ok(batch)) => Ok(batch.into()),
- Some(Err(e)) => Err(PyDataFusionError::from(e))?,
- None => {
+ match poll_next_batch(&mut stream).await {
Review Comment:
`poll_next_batch` was created to encapsulate the recurring asynchronous
polling pattern used when consuming the stream. Centralizing this behavior
improves readability, prevents duplicated error-mapping logic, facilitates unit
testing, and enables future enhancements without modifying multiple call sites.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
