alamb commented on code in PR #17524:
URL: https://github.com/apache/datafusion/pull/17524#discussion_r2352753625
##########
datafusion/expr/src/expr_fn.rs:
##########
@@ -71,7 +71,15 @@ pub fn col(ident: impl Into<Column>) -> Expr {
/// Create an out reference column which hold a reference that has been
resolved to a field
/// outside of the current plan.
pub fn out_ref_col(dt: DataType, ident: impl Into<Column>) -> Expr {
- Expr::OuterReferenceColumn(dt, ident.into())
+ // Construct a synthetic field (no metadata). Prefer using `out_ref_field`
when possible
+ let column = ident.into();
Review Comment:
Rather than removing it, how about we mark it "deprecated" per
https://datafusion.apache.org/contributor-guide/api-health.html#deprecation-guidelines?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
