2010YOUY01 commented on PR #17606: URL: https://github.com/apache/datafusion/pull/17606#issuecomment-3301434951
I think it's better to do a PoC with performance numbers before splitting the work into individual PRs. This counting distinct seems a bit expensive, is it possible to infer that from some plan properties? Also I think it's a good idea to implement a micro-benchmark for HJ similar to https://github.com/apache/datafusion/blob/main/benchmarks/src/nlj.rs if we want to do further optimizations -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
