andygrove commented on code in PR #2407:
URL: https://github.com/apache/datafusion-comet/pull/2407#discussion_r2353684089
##########
spark/src/test/scala/org/apache/spark/sql/benchmark/CometAggregateBenchmark.scala:
##########
@@ -64,13 +64,7 @@ object CometAggregateBenchmark extends CometBenchmarkBase {
spark.sql(query).noop()
}
- benchmark.addCase(s"SQL Parquet - Comet (Scan) ($aggregateFunction)")
{ _ =>
- withSQLConf(CometConf.COMET_ENABLED.key -> "true") {
- spark.sql(query).noop()
- }
- }
Review Comment:
It no longer makes sense to benchmark Comet with `Scan` vs `Scan & Exec`
configurations, especially for aggregates. Comet scans won't accelerate
aggregates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
