jackkleeman commented on code in PR #17476: URL: https://github.com/apache/datafusion/pull/17476#discussion_r2336102151
########## datafusion/physical-plan/src/joins/utils.rs: ########## @@ -2069,20 +2077,25 @@ mod tests { (10, Absent, Absent, Absent, Absent), None, ), - // No min or max (or both). + // No min or max (or both), but distinct available. ( (10, Absent, Absent, Inexact(3), Absent), (10, Absent, Absent, Inexact(3), Absent), - None, + Some(Inexact(33)), Review Comment: the behaviour of these two have changed because we will use the distinct values even though we have no range -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org