andygrove commented on code in PR #2384:
URL: https://github.com/apache/datafusion-comet/pull/2384#discussion_r2353777772
##########
native/spark-expr/Cargo.toml:
##########
@@ -37,6 +37,10 @@ thiserror = { workspace = true }
futures = { workspace = true }
twox-hash = "2.1.2"
rand = { workspace = true }
+datafusion-comet-proto = { workspace = true }
Review Comment:
We currently publish the `datafusion-comet-spark-expr` crate to crates.io,
so adding a dependency on `datafusion-comet-proto` means that we either need to
stop publishing `datafusion-comet-spark-expr` (which was the eventual plan
anyway, see https://github.com/apache/datafusion-comet/pull/2405) or we need to
start publishing `datafusion-comet-proto` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
