milenkovicm commented on code in PR #17650:
URL: https://github.com/apache/datafusion/pull/17650#discussion_r2362719221
##########
datafusion/expr/src/registry.rs:
##########
@@ -27,9 +27,15 @@ use std::sync::Arc;
/// A registry knows how to build logical expressions out of user-defined
function' names
pub trait FunctionRegistry {
- /// Set of all available udfs.
+ /// Returns names of all available scalar user defined functions.
fn udfs(&self) -> HashSet<String>;
+ /// Returns names of all available aggregate user defined functions.
+ fn udafs(&self) -> HashSet<String>;
+
+ /// Returns names of all available window user defined functions.
+ fn udwfs(&self) -> HashSet<String>;
Review Comment:
I just wonder should make this methods with default implementation (empty
set) for 50.1 release and revert it to unimplemeted for 51.0
##########
datafusion/expr/src/registry.rs:
##########
@@ -27,9 +27,15 @@ use std::sync::Arc;
/// A registry knows how to build logical expressions out of user-defined
function' names
pub trait FunctionRegistry {
- /// Set of all available udfs.
+ /// Returns names of all available scalar user defined functions.
fn udfs(&self) -> HashSet<String>;
+ /// Returns names of all available aggregate user defined functions.
+ fn udafs(&self) -> HashSet<String>;
+
+ /// Returns names of all available window user defined functions.
+ fn udwfs(&self) -> HashSet<String>;
Review Comment:
I just wonder should make this methods with default implementation (empty
set) for 50.1 release and revert it to unimplemented for 51.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
