jonathanc-n commented on code in PR #17580:
URL: https://github.com/apache/datafusion/pull/17580#discussion_r2353081903
##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -790,9 +790,26 @@ impl SessionContext {
}
if exist {
- match cmd.if_not_exists {
- true => return self.return_empty_dataframe(),
- false => {
+ match (cmd.if_not_exists, cmd.or_replace) {
+ (true, false) => return self.return_empty_dataframe(),
+ (false, true) => {
+ let result = self
+ .find_and_deregister(cmd.name.clone(), TableType::Base)
+ .await;
+ match result {
+ Ok(true) => {
+ let table_provider: Arc<dyn TableProvider> =
+ self.create_custom_table(cmd).await?;
+ self.register_table(cmd.name.clone(),
table_provider)?;
+ return self.return_empty_dataframe();
+ }
+ _ => return exec_err!("View '{}' doesn't exist.",
cmd.name),
Review Comment:
This entire clause is wrapped by an `exist` flag, so it shouldnt be able to
return Ok(false). I could just refactor the whole logic to be similar to how
memory table handles the flags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
