AdamGS commented on code in PR #17808:
URL: https://github.com/apache/datafusion/pull/17808#discussion_r2387466774
##########
datafusion/spark/src/function/math/width_bucket.rs:
##########
@@ -96,7 +96,14 @@ impl ScalarUDFImpl for SparkWidthBucket {
let is_num = |t: &DataType| {
matches!(
t,
- Int8 | Int16 | Int32 | Int64 | Float32 | Float64 |
Decimal128(_, _)
+ Int8 | Int16
+ | Int32
+ | Int64
+ | Float32
+ | Float64
+ | Decimal32(_, _)
+ | Decimal64(_, _)
+ | Decimal128(_, _)
Review Comment:
That seems like its probably fine, also talked to my local Spark expert and
seems like it should be fine (+ I assume there are other places where we deal
with the conversion to spark's type system)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
