Jefffrey commented on PR #17884:
URL: https://github.com/apache/datafusion/pull/17884#issuecomment-3361245250
> @Jefffrey I'm fixing the failing test. While I'm at it I'm considering
adding another change in this PR that uses Display for the set elements rather
than Debug. The output now is way too verbose imo.
>
> Example from one of the test cases:
>
> rather than
>
> ```
> a@0 IN (SET) ([Literal { value: Utf8("a"), field: Field { name: "lit",
data_type: Utf8, nullable: false, dict_id: 0, dict_is_ordered: false, metadata:
{} } }, Literal { value: Utf8("b"), field: Field { name: "lit", data_type:
Utf8, nullable: false, d ...
> ```
>
> we would get
>
> ```
> a@0 IN (SET) ([a, b, NULL])
> ```
>
> is that ok to include or should I make a separate PR?
I think that's a great idea to include in this PR; I recall a recent PR
where we saw this debug display too which was a bit ugly:
https://github.com/apache/datafusion/pull/17732#discussion_r2373055683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
