Omega359 commented on code in PR #18017:
URL: https://github.com/apache/datafusion/pull/18017#discussion_r2429760157
##########
datafusion/expr/src/udf.rs:
##########
@@ -532,6 +536,11 @@ pub trait ScalarUDFImpl: Debug + DynEq + DynHash + Send +
Sync {
/// [`DataFusionError::Internal`]:
datafusion_common::DataFusionError::Internal
fn return_type(&self, arg_types: &[DataType]) -> Result<DataType>;
+
+ fn need_config(&self) -> bool {
Review Comment:
I believe this would be better without &self so that it could be called as
an associated function rather than a method on an instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
