pepijnve commented on code in PR #17813:
URL: https://github.com/apache/datafusion/pull/17813#discussion_r2436653038
##########
datafusion/core/tests/tpcds_planning.rs:
##########
@@ -1052,9 +1052,12 @@ async fn regression_test(query_no: u8, create_physical:
bool) -> Result<()> {
for sql in &sql {
let df = ctx.sql(sql).await?;
let (state, plan) = df.into_parts();
- let plan = state.optimize(&plan)?;
if create_physical {
let _ = state.create_physical_plan(&plan).await?;
Review Comment:
To see what I'm talking about, comment out this line on `main` and run
`tpcds_physical_q75`. You'll get
```
Error: Internal("Physical input schema should be the same as the one
converted from logical input schema. Differences: \n\t- field nullability at
index 5 [sales_cnt]: (physical) true vs (logical) false\n\t- field nullability
at index 6 [sales_amt]: (physical) true vs (logical) false")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
