gabotechs commented on code in PR #18099:
URL: https://github.com/apache/datafusion/pull/18099#discussion_r2437116043
##########
datafusion/expr-common/src/type_coercion/binary.rs:
##########
@@ -866,6 +866,7 @@ pub fn comparison_coercion_numeric(
return Some(lhs_type.clone());
}
binary_numeric_coercion(lhs_type, rhs_type)
+ .or_else(|| dictionary_comparison_coercion_numeric(lhs_type, rhs_type,
true))
Review Comment:
How it is that we cannot just do:
```rust
binary_numeric_coercion(lhs_type, rhs_type)
+ .or_else(|| dictionary_comparison_coercion(lhs_type, rhs_type,
true))
```
And instead we need to split the `dictionary_comparison_coercion()` in two?
I see that by just using the old `dictionary_comparision_coercion()`
function is enought for making the `cargo test --test sqllogictests --
nullif.slt` test pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
