comphead commented on code in PR #2258:
URL: https://github.com/apache/datafusion-comet/pull/2258#discussion_r2373951786
##########
native/core/src/execution/shuffle/comet_partitioning.rs:
##########
@@ -26,15 +27,15 @@ pub enum CometPartitioning {
Hash(Vec<Arc<dyn PhysicalExpr>>, usize),
/// Allocate rows based on the lexical order of one of more expressions
and the specified number of
Review Comment:
Sorry for misleading comment.
I was thinking if to compare with others variants like Hash
```
Hash(Vec<Arc<dyn PhysicalExpr>>, usize),
```
it is quite intuitive that hash depends on numPartitions and expression that
supposed to be hashed.
for Range it is
```
RangePartitioning(LexOrdering, usize, Arc<RowConverter>, Vec<OwnedRow>),
```
which looks no so intuitive IMO, because cannot say when reading what is the
meaning of last 2 params.
Anyway, this design question can be addressed in follow up if needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
