pepijnve commented on code in PR #18097:
URL: https://github.com/apache/datafusion/pull/18097#discussion_r2438680178
##########
datafusion/physical-expr/benches/case_when.rs:
##########
@@ -16,30 +16,29 @@
// under the License.
use arrow::array::builder::{Int32Builder, StringBuilder};
-use arrow::datatypes::{DataType, Field, Schema};
+use arrow::array::{Array, ArrayRef, Int32Array};
+use arrow::datatypes::{Field, Schema};
use arrow::record_batch::RecordBatch;
use criterion::{black_box, criterion_group, criterion_main, Criterion};
-use datafusion_common::ScalarValue;
use datafusion_expr::Operator;
-use datafusion_physical_expr::expressions::{BinaryExpr, CaseExpr, Column,
Literal};
+use datafusion_physical_expr::expressions::{case, col, lit, BinaryExpr};
use datafusion_physical_expr_common::physical_expr::PhysicalExpr;
use std::sync::Arc;
-fn make_col(name: &str, index: usize) -> Arc<dyn PhysicalExpr> {
- Arc::new(Column::new(name, index))
+fn make_x_cmp_y(
+ x: &Arc<dyn PhysicalExpr>,
+ op: Operator,
+ y: i32,
+) -> Arc<dyn PhysicalExpr> {
+ Arc::new(BinaryExpr::new(Arc::clone(x), op, lit(y)))
}
-fn make_lit_i32(n: i32) -> Arc<dyn PhysicalExpr> {
- Arc::new(Literal::new(ScalarValue::Int32(Some(n))))
-}
-
-fn criterion_benchmark(c: &mut Criterion) {
- // create input data
+fn make_batch(row_count: usize, column_count: usize) -> RecordBatch {
Review Comment:
I'll add a description and assertion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
