andy-hf-kwok commented on code in PR #2527:
URL: https://github.com/apache/datafusion-comet/pull/2527#discussion_r2411370649
##########
common/src/main/scala/org/apache/spark/sql/comet/util/Utils.scala:
##########
@@ -223,9 +223,9 @@ object Utils extends CometTypeShim {
writer.close()
if (out.size() > 0) {
- (batch.numRows(), cbbos.toChunkedByteBuffer)
+ (batch.numRows().toLong, cbbos.toChunkedByteBuffer)
Review Comment:
That is correct, indeed even now the conversion happen implicitly anyway.
If making it explicit can dismiss the warning, it's better in this way I
reckon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
