comphead commented on code in PR #2521:
URL: https://github.com/apache/datafusion-comet/pull/2521#discussion_r2402898808
##########
spark/src/main/scala/org/apache/comet/CometExecIterator.scala:
##########
@@ -87,9 +87,9 @@ class CometExecIterator(
CometSparkSessionExtensions.getCometMemoryOverhead(conf)
}
- // serialize Spark conf in protobuf format
+ // serialize Comet configs in protobuf format
Review Comment:
I'm also thinking don't we need usual spark params on native side? like
`spark.sql.ansi.enabled`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
