bubulalabu commented on code in PR #18022: URL: https://github.com/apache/datafusion/pull/18022#discussion_r2443434248
########## datafusion/sqllogictest/test_files/table_functions.slt: ########## @@ -494,3 +494,32 @@ SELECT c, f.* FROM json_table, LATERAL generate_series(1,2) f; 1 2 2 1 2 2 + +# +# Test schema-qualified table function names (Phase 3) +# Global table functions are not accessible via qualified names +# + +# Test: unqualified table function name resolves from global registry (backward compatibility) +query I +SELECT * FROM generate_series(1, 3) +---- +1 +2 +3 + +# Test: qualified name for global table function should fail +# (global table functions are not in schemas, they're in the global registry) +statement error DataFusion error: Error during planning: Table function 'public.generate_series' not found in schema +SELECT * FROM public.generate_series(1, 3) Review Comment: That way we won't have a global registry anymore and `ctx.register_udtf()` would register the table function with the public schema. Please let me know if that's what we want and I'll add it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
