andygrove commented on PR #2614: URL: https://github.com/apache/datafusion-comet/pull/2614#issuecomment-3428637615
> > > It really doesn't. As an example, if we add a new function that only exists in Spark 4.0 then run the fuzz test against an older version, the query will fail both with Spark and Comet, so that is a pass. > > > > > > What if the signature changes in a new Spark release? Then it would start failing for Spark and Comet (and thus pass)? > > I'm just trying to understand what the maintenance process is for future releases, and how to potentially document that. > > That is true. This is all very manual at the moment. > > I briefly looked into using Spark APIs to get the signature, but there are some challenges. We can look at classes to see if they extend `UnaryExpression` or `BinaryExpression`, but to determine the valid input data types we would need to create an instance of the class, which seems challenging. @mbutrovich One option I would like to explore is to produce a summary report after running the queries, which would show how many successful queries ran for each expression and show error messages for any expressions that always failed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
