mbutrovich commented on code in PR #2629:
URL: https://github.com/apache/datafusion-comet/pull/2629#discussion_r2452961098
##########
spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala:
##########
@@ -45,7 +45,13 @@ class CometAggregateSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
val filename = path.toString
val random = new Random(42)
withSQLConf(CometConf.COMET_ENABLED.key -> "false") {
- ParquetGenerator.makeParquetFile(random, spark, filename, 10000,
DataGenOptions())
+ ParquetGenerator.makeParquetFile(
+ random,
+ spark,
+ filename,
+ 10000,
+ SchemaGenOptions(),
+ DataGenOptions())
Review Comment:
Just a clarification for my understanding since I think it could be
ambiguous: Is this intended to use the constructor for `DataGenOptions` or the
default value in CometTestBase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
