alamb commented on PR #17986: URL: https://github.com/apache/datafusion/pull/17986#issuecomment-3434122276
In my opinion, there are several things we could improve in this PR, such as the conversion of DataType <> Field but we can do them as follow ons as well (given this one is already pretty big). Thank you @paleolimbot and @tobixdev for helping blaze the trail. I suggest we 1. Address as many comments as feasible on this PR 2. File any follow on issues to track improvements 3. Merge it in and keep iterating. The only thing I would really like to see changed is renaming `LiteralValue` to something less confusing, but even that is fine to do as a follow on PR I think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
