parthchandra commented on code in PR #2615:
URL: https://github.com/apache/datafusion-comet/pull/2615#discussion_r2455963845


##########
common/src/main/java/org/apache/comet/parquet/NativeBatchReader.java:
##########
@@ -214,7 +217,8 @@ private NativeBatchReader(AbstractColumnReader[] 
columnReaders) {
       boolean useLegacyDateTimestamp,
       StructType partitionSchema,
       InternalRow partitionValues,
-      Map<String, SQLMetric> metrics) {
+      Map<String, SQLMetric> metrics,

Review Comment:
   Took a deeper look and while it is passed in to the `FileReader` 
constructor, it is not necessary for `NativeBatchReader`. Logged an issue to 
clean it up (https://github.com/apache/datafusion-comet/issues/2641).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to