Jefffrey commented on code in PR #18100:
URL: https://github.com/apache/datafusion/pull/18100#discussion_r2458226290
##########
datafusion/ffi/src/udaf/accumulator_args.rs:
##########
@@ -97,6 +97,7 @@ impl TryFrom<AccumulatorArgs<'_>> for FFI_AccumulatorArgs {
pub struct ForeignAccumulatorArgs {
pub return_field: FieldRef,
pub schema: Schema,
+ pub expr_fields: Vec<FieldRef>,
Review Comment:
I don't _think_ so, since `FFI_AccumulatorArgs` seems to be the one marked
as being stable across FFI boundaries:
https://github.com/apache/datafusion/blob/9f23680eb4c72905bb175df9ff01f00c1821e1c4/datafusion/ffi/src/udaf/accumulator_args.rs#L44-L56
Though I am not familiar with the FFI related code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
