alamb commented on code in PR #18051:
URL: https://github.com/apache/datafusion/pull/18051#discussion_r2460721281
##########
docs/source/user-guide/sql/scalar_functions.md:
##########
@@ -2444,7 +2444,6 @@ date_bin(interval, expression, origin-timestamp)
- **interval**: Bin interval.
- **expression**: Time expression to operate on. Can be a constant, column, or
function.
- **origin-timestamp**: Optional. Starting point used to determine bin
boundaries. If not specified defaults 1970-01-01T00:00:00Z (the UNIX epoch in
UTC). The following intervals are supported:
-
Review Comment:
reverted in 09d6ca6ba955dda9d9dcb988df24c97040d8889a
##########
datafusion/core/src/lib.rs:
##########
@@ -897,6 +920,12 @@ doc_comment::doctest!("../../../README.md",
readme_example_test);
// For example, if `user_guide_expressions(line 123)` fails,
// go to `docs/source/user-guide/expressions.md` to find the relevant problem.
//
+#[cfg(doctest)]
Review Comment:
this will now run the examples as part of CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
