Re: [PR] feat(docs): Enable dark mode toggle [datafusion]

Mon, 27 Oct 2025 07:43:13 -0700 


Jefffrey commented on PR #18285:
URL: https://github.com/apache/datafusion/pull/18285#issuecomment-3451647274

   > hey @alamb
   > 
   > > However, when I tested this locally I didn't see any switcher buttons
   > 
   > apparently to view the toggle we need unblock the navbar by removing the 
following part in file `docs/source/_templates/layout.html` (line 3-5)
   > 
   > > {# Silence the navbar #}
   > > {% block docs_navbar %}
   > > {% endblock %}
   > 
   > so this would result in something like this <img alt="image" width="1479" 
height="377" 
src="https://private-user-images.githubusercontent.com/170395811/506058256-d97cb872-c137-4d5e-b686-40bbe9e9bb14.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjE1NzYzOTIsIm5iZiI6MTc2MTU3NjA5MiwicGF0aCI6Ii8xNzAzOTU4MTEvNTA2MDU4MjU2LWQ5N2NiODcyLWMxMzctNGQ1ZS1iNjg2LTQwYmJlOWU5YmIxNC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUxMDI3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MTAyN1QxNDQxMzJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xYWM2MmE1YTM2NzFlZmVlOTg0MzA2YmZlNTZlOGY4NDE4NjY5OGJmZDBiZjJiMzIzMmIwNmE0MGI3NTkyYzBiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.1PkHocavNqFMc3hH6xrzyg8T-hzBJDXVRKdQAMgNHKw";>
   > 
   > just a quick question "Is the navbar blocked for any reason ??"
   
   I assume it's blocked to avoid having that top bar of links which doesn't 
look particularly good (at least in its default form)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to