watford-ep commented on code in PR #2079:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2079#discussion_r2477983494
##########
src/dialect/mod.rs:
##########
@@ -1207,6 +1207,17 @@ pub trait Dialect: Debug + Any {
fn supports_semantic_view_table_factor(&self) -> bool {
false
}
+
+ /// Returns true if the dialect supports the `RESET` statement
+ /// for resetting session variables.
+ ///
+ /// ```sql
+ /// RESET configuration_parameter;
+ /// RESET ALL;
+ /// ```
+ fn supports_reset(&self) -> bool {
+ false
+ }
Review Comment:
I updated the ticket to include exactly which dialects support RESET, and
its a bit touch and go. Right now this seems reasonable (in that it accepts a
very reasonable use, though not strictly correct for all dialects).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
