cj-zhukov commented on PR #18289: URL: https://github.com/apache/datafusion/pull/18289#issuecomment-3476107366
> Thank you @cj-zhukov -- this is an exciting idea but I think it is going to be very hard to review a PR of this size (it will require a substantial amount of contingiuous review time, which is quite hard to find) > > Is there any way to break it up into smaller pieces? > > For example, perhaps you could consolidate all the `flight` examples into a single example binary as a single PR? > > Then we can make sure we are agreed on the pattern and then we can apply it to the remaining examples Thank you for the feedback! That makes perfect sense - I agree it’ll be much easier to review and discuss the approach in smaller steps. I’ll start by creating a separate PR that consolidates the `flight` examples into a single example binary using this pattern. Once that’s reviewed and agreed upon, I can apply the same structure to the remaining examples. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
