comphead commented on code in PR #2693:
URL: https://github.com/apache/datafusion-comet/pull/2693#discussion_r2495823594
##########
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##########
@@ -108,14 +108,26 @@ abstract class CometTestBase
excludedClasses: Seq[Class[_]] = Seq.empty,
withTol: Option[Double] = None): (SparkPlan, SparkPlan) = {
+ val showAnswers = CometConf.COMET_TEST_SHOW_ANSWERS.get()
+
var expected: Array[Row] = Array.empty
var sparkPlan = null.asInstanceOf[SparkPlan]
withSQLConf(CometConf.COMET_ENABLED.key -> "false") {
val dfSpark = datasetOfRows(spark, df.logicalPlan)
expected = dfSpark.collect()
sparkPlan = dfSpark.queryExecution.executedPlan
+ if (showAnswers) {
Review Comment:
by default it is 20 rows outputted, would be that enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
