eyalleshem commented on issue #2036: URL: https://github.com/apache/datafusion-sqlparser-rs/issues/2036#issuecomment-3506790296
@alamb @iffyio - I'm noticing that the PR for adding lifetimes to the Token enum is becoming quite complex. I don't think it's a good idea to merge the PRs I've already opened to master before we confirm the approach is viable. However, I also don't want to delay reviews and feedback until all the code is complete. I'd like to suggest creating a feature branch where we can open and merge related PRs for this issue. Once we've proven the concept adds real value to the project, we can then merge the complete feature to master. What do you think?" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
