comphead commented on code in PR #2748:
URL: https://github.com/apache/datafusion-comet/pull/2748#discussion_r2511560863
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -1066,7 +1094,6 @@ object QueryPlanSerde extends Logging with CometExprShim {
case _: CollectLimitExec => true
case _: UnionExec => true
case _: TakeOrderedAndProjectExec => true
- case _: WindowExec => true
Review Comment:
WindowExec was added here because it was related to `TakeOrderedProjectExec`
which was added here previuosly, but you are right, it is most likely the
reason, why the operator doesn't fallback to Spark in clean way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
