viirya commented on code in PR #18617:
URL: https://github.com/apache/datafusion/pull/18617#discussion_r2514721067
##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -1627,7 +1627,9 @@ async fn register_table() -> Result<()> {
let df_impl = DataFrame::new(ctx.state(), df.logical_plan().clone());
// register a dataframe as a table
- ctx.register_table("test_table", df_impl.clone().into_view())?;
+ let table_provider = df_impl.clone().into_view();
+ assert_eq!(table_provider.table_type(), TableType::View);
+ ctx.register_table("test_table", table_provider)?;
Review Comment:
This `TableType::View` assert is the only one test check for `into_view` and
it is in a test that looks like not added particularly for it. That's said it
is very possible it will be forgotten easily.
Maybe just add a simple test specific for `into_view`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
