2010YOUY01 commented on code in PR #18644:
URL: https://github.com/apache/datafusion/pull/18644#discussion_r2525556621
##########
datafusion/physical-plan/src/aggregates/no_grouping.rs:
##########
@@ -101,27 +303,32 @@ impl AggregateStream {
accumulators,
reservation,
finished: false,
+ agg_dyn_filter_state: maybe_dynamic_filter,
};
+
let stream = futures::stream::unfold(inner, |mut this| async move {
if this.finished {
return None;
}
- let elapsed_compute = this.baseline_metrics.elapsed_compute();
-
loop {
let result = match this.input.next().await {
Some(Ok(batch)) => {
- let timer = elapsed_compute.timer();
- let result = aggregate_batch(
- &this.mode,
- batch,
- &mut this.accumulators,
- &this.aggregate_expressions,
- &this.filter_expressions,
- );
+ let result = {
+ let elapsed_compute =
this.baseline_metrics.elapsed_compute();
+ let timer = elapsed_compute.timer();
+ let result = aggregate_batch(
+ &this.mode,
+ batch,
+ &mut this.accumulators,
+ &this.aggregate_expressions,
+ &this.filter_expressions,
+ );
+ timer.done();
+ result
+ };
- timer.done();
+ let _ = this.maybe_update_dyn_filter();
Review Comment:
fixed in
[775c45b](https://github.com/apache/datafusion/pull/18644/commits/775c45b29ab078dea46c0de3061923b49c6436ff)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
