codetyri0n commented on code in PR #18674:
URL: https://github.com/apache/datafusion/pull/18674#discussion_r2527770189
##########
datafusion/spark/src/function/conditional/if.rs:
##########
@@ -80,7 +80,8 @@ impl ScalarUDFImpl for SparkIf {
}
fn invoke_with_args(&self, _args: ScalarFunctionArgs) ->
Result<ColumnarValue> {
- internal_err!("if should have been simplified to case")
+ assert_or_internal_err!(false, "if should have been simplified to
case");
+ unreachable!()
Review Comment:
yup, my apologies I forgot to revert this change (and the on below as well
🤦🏽 ). : )
##########
datafusion/spark/src/function/conditional/if.rs:
##########
@@ -80,7 +80,8 @@ impl ScalarUDFImpl for SparkIf {
}
fn invoke_with_args(&self, _args: ScalarFunctionArgs) ->
Result<ColumnarValue> {
- internal_err!("if should have been simplified to case")
+ assert_or_internal_err!(false, "if should have been simplified to
case");
+ unreachable!()
Review Comment:
yup, my apologies I forgot to revert this change (and the one below as well
🤦🏽 ). : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
