adriangb commented on PR #18449: URL: https://github.com/apache/datafusion/pull/18449#issuecomment-3534803679
Yay we got the performance back, and then some! @alamb I need to resolve a ton of conflicts now. And I’d like to take the opportunity to benchmark with/without: - the enum for make_comparator. I’m leaning toward removing it if it doesn’t make a big difference and focusing on the arrow PR where we can more directly prove any performance improvement. - the thread local for the hashes buffer, I want to see if it actually helps or hurts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
